Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19810 )
Change subject: IMPALA-12102: This patch avoids memory leaks due to the large number of JNI exceptions thrown ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/19810/2/tests/query_test/test_udfs.py File tests/query_test/test_udfs.py: http://gerrit.cloudera.org:8080/#/c/19810/2/tests/query_test/test_udfs.py@695 PS2, Line 695: def test_throws_exception(self, vector, unique_database): > Ack I'm not sure how we could verify that there's no leak in a test.. Could you manually verify that the leak doesn't happen after this change? If so, you could write in the commit message in the Testing section that you manually verified that the problem doesn't occur. -- To view, visit http://gerrit.cloudera.org:8080/19810 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4843df07dd0f9d3dc237f91db4ec00721ebbd680 Gerrit-Change-Number: 19810 Gerrit-PatchSet: 2 Gerrit-Owner: ttttttz <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: ttttttz <[email protected]> Gerrit-Comment-Date: Fri, 28 Apr 2023 09:39:54 +0000 Gerrit-HasComments: Yes
