Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19745 )
Change subject: IMPALA-11970: Shifting the timeline display to SVG ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/19745/4/www/query_timeline.tmpl File www/query_timeline.tmpl: http://gerrit.cloudera.org:8080/#/c/19745/4/www/query_timeline.tmpl@100 PS4, Line 100: = nit: add space around = http://gerrit.cloudera.org:8080/#/c/19745/4/www/query_timeline.tmpl@495 PS4, Line 495: x + px_per_tic - decimals * 6 Why is "0.00" shown on the right side of the first box? "0.00" as starting time should be shown on the left end of the first box. Maybe show two numbers in last box on each end so that the ending time is shown on the right side of the last box. nit: remove space before ',' -- To view, visit http://gerrit.cloudera.org:8080/19745 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I083c2ec12e1743b89092fc23281ee576d66fa81b Gerrit-Change-Number: 19745 Gerrit-PatchSet: 4 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 02 May 2023 22:02:41 +0000 Gerrit-HasComments: Yes
