Kurt Deschler has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19745 )

Change subject: IMPALA-11970: Shifting the timeline display to SVG
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19745/4/www/query_timeline.tmpl
File www/query_timeline.tmpl:

http://gerrit.cloudera.org:8080/#/c/19745/4/www/query_timeline.tmpl@495
PS4, Line 495: x + px_per_tic - decimals * 6
> Why is "0.00" shown on the right side of the first box? "0.00" as starting
Timestamps should be on the right so we know the end time but they should not 
start at 0. This isn't a new issue. I will enter a separate ticket and post a 
fix then we can rebase this patch on top for consistency.



--
To view, visit http://gerrit.cloudera.org:8080/19745
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I083c2ec12e1743b89092fc23281ee576d66fa81b
Gerrit-Change-Number: 19745
Gerrit-PatchSet: 4
Gerrit-Owner: Surya Hebbar <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Kurt Deschler <[email protected]>
Gerrit-Reviewer: Surya Hebbar <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
Gerrit-Comment-Date: Wed, 03 May 2023 14:08:59 +0000
Gerrit-HasComments: Yes

Reply via email to