Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19185 )
Change subject: PROTOTYPE IMPALA-11694: Convert gutil atomic ops to C++ atomics ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/19185/4/be/src/gutil/atomicops-internals-x86.h File be/src/gutil/atomicops-internals-x86.h: http://gerrit.cloudera.org:8080/#/c/19185/4/be/src/gutil/atomicops-internals-x86.h@36 PS4, Line 36: // This struct is not part of the public API of this module; clients may not : // use it. : // Features of this x86. Values may not be correct before InitGoogle() is run, : // but are set conservatively. : struct AtomicOps_x86CPUFeatureStruct { : bool has_sse2; // Processor has SSE2. : bool has_cmpxchg16b; // Processor supports cmpxchg16b instruction. : }; : extern struct AtomicOps_x86CPUFeatureStruct AtomicOps_Internalx86CPUFeatures; : : // AtomicOps initialisation for open source use. : void AtomicOps_x86CPUFeaturesInit(); This may not be needed after the switch (and the corresponding .cc file can be removed along with the call from be/src/common/init.cc). There is already code in be/src/util/cpu-info.h/.cc to detect the CPU for other purposes, and the code no longer needs this structure. http://gerrit.cloudera.org:8080/#/c/19185/4/be/src/gutil/atomicops.h File be/src/gutil/atomicops.h: http://gerrit.cloudera.org:8080/#/c/19185/4/be/src/gutil/atomicops.h@41 PS4, Line 41: typedef int64_t Atomci64; Typo: Atomic64 -- To view, visit http://gerrit.cloudera.org:8080/19185 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d1e3f4e71988a6c464071c1cd8bdebce622e4b8 Gerrit-Change-Number: 19185 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Fri, 05 May 2023 05:30:23 +0000 Gerrit-HasComments: Yes
