[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/19185 )
Change subject: PROTOTYPE IMPALA-11694: Convert gutil atomic ops to C++ atomics ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/19185/5/be/src/gutil/atomicops-internals-portable.h File be/src/gutil/atomicops-internals-portable.h: http://gerrit.cloudera.org:8080/#/c/19185/5/be/src/gutil/atomicops-internals-portable.h@48 PS5, Line 48: inline Atomic32 NoBarrier_CompareAndSwap(volatile Atomic32* ptr, I verified that the code produced by every function in this file generates the same output as the inline assembly (the code removed from atomicops-internals-arm64.h) on arm64 when compiled for ARMv8-a: $ g++ -O2 -S -o- a.cc -march=armv8-a -mno-outline-atomics I also have reviewed the output of the compiler when generating code for ARMv8.2-a: $ g++ -O2 -S -o- a.cc -march=armv8.2-a -mno-outline-atomics http://gerrit.cloudera.org:8080/#/c/19185/5/be/src/gutil/atomicops.h File be/src/gutil/atomicops.h: http://gerrit.cloudera.org:8080/#/c/19185/5/be/src/gutil/atomicops.h@148 PS5, Line 148: // Platform specific pieces (currently only PauseCPU and processor information for x86 Would it make sense to move PauseCPU to be/src/common/atomic.h? -- To view, visit http://gerrit.cloudera.org:8080/19185 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d1e3f4e71988a6c464071c1cd8bdebce622e4b8 Gerrit-Change-Number: 19185 Gerrit-PatchSet: 5 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Fri, 05 May 2023 15:38:17 +0000 Gerrit-HasComments: Yes
