Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19185 )
Change subject: PROTOTYPE IMPALA-11694: Convert gutil atomic ops to C++ atomics ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/19185/5/be/src/gutil/atomicops.h File be/src/gutil/atomicops.h: http://gerrit.cloudera.org:8080/#/c/19185/5/be/src/gutil/atomicops.h@148 PS5, Line 148: // Platform specific pieces (currently only PauseCPU and processor information for x86 > Would it make sense to move PauseCPU to be/src/common/atomic.h? I think we could pull it out to its own header file in be/src/gutil. Chromium has a yield_processor.h file and that seems reasonable. https://github.com/chromium/chromium/blob/main/base/allocator/partition_allocator/yield_processor.h Keeping the name base::subtle::PauseCPU() would be useful to avoid disruption. -- To view, visit http://gerrit.cloudera.org:8080/19185 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d1e3f4e71988a6c464071c1cd8bdebce622e4b8 Gerrit-Change-Number: 19185 Gerrit-PatchSet: 5 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Fri, 05 May 2023 19:41:01 +0000 Gerrit-HasComments: Yes
