Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19807 )
Change subject: IMPALA-12091: Control scan parallelism by its processing cost ...................................................................... Patch Set 6: (7 comments) http://gerrit.cloudera.org:8080/#/c/19807/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19807/6//COMMIT_MSG@28 PS6, Line 28: is nit: are http://gerrit.cloudera.org:8080/#/c/19807/6/be/src/scheduling/scheduler.cc File be/src/scheduling/scheduler.cc: http://gerrit.cloudera.org:8080/#/c/19807/6/be/src/scheduling/scheduler.cc@285 PS6, Line 285: fragment_state->instance_states.empty() Is it possible fragment_state->instance_states is empty()? num_host as 0 is not handled in line 317. http://gerrit.cloudera.org:8080/#/c/19807/6/be/src/scheduling/scheduler.cc@286 PS6, Line 286: 1 0. Otherwise if fragment_state->instance_states.size() equals 1, index is out of range. http://gerrit.cloudera.org:8080/#/c/19807/6/be/src/scheduling/scheduler.cc@305 PS6, Line 305: fragment_state->instance_states.size() fragment_state->instance_states.size() - 1 http://gerrit.cloudera.org:8080/#/c/19807/6/common/thrift/ImpalaService.thrift File common/thrift/ImpalaService.thrift: http://gerrit.cloudera.org:8080/#/c/19807/6/common/thrift/ImpalaService.thrift@787 PS6, Line 787: host nit: node http://gerrit.cloudera.org:8080/#/c/19807/6/common/thrift/Query.thrift File common/thrift/Query.thrift: http://gerrit.cloudera.org:8080/#/c/19807/6/common/thrift/Query.thrift@114 PS6, Line 114: const i32 MAX_FRAGMENT_INSTANCES_PER_NODE = 128 nit: add a comment for this new constant since it's not for TQueryOption.num_nodes http://gerrit.cloudera.org:8080/#/c/19807/6/fe/src/main/java/org/apache/impala/planner/PlanFragment.java File fe/src/main/java/org/apache/impala/planner/PlanFragment.java: http://gerrit.cloudera.org:8080/#/c/19807/6/fe/src/main/java/org/apache/impala/planner/PlanFragment.java@1110 PS6, Line 1110: canTryLower = false; move out of loop? -- To view, visit http://gerrit.cloudera.org:8080/19807 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If948e45455275d9a61a6cd5d6a30a8b98a7c729a Gerrit-Change-Number: 19807 Gerrit-PatchSet: 6 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 09 May 2023 05:54:30 +0000 Gerrit-HasComments: Yes
