Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19807 )
Change subject: IMPALA-12091: Control scan parallelism by its processing cost ...................................................................... Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/19807/7/be/src/service/query-options-test.cc File be/src/service/query-options-test.cc: http://gerrit.cloudera.org:8080/#/c/19807/7/be/src/service/query-options-test.cc@262 PS7, Line 262: {MAKE_OPTIONDEF(max_fs_writers), {0, I32_MAX}}, : {MAKE_OPTIONDEF(default_ndv_scale), {1, 10}}, > replace 128 with new constant MAX_FRAGMENT_INSTANCES_PER_NODE Done http://gerrit.cloudera.org:8080/#/c/19807/7/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/19807/7/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@654 PS7, Line 654: tions.checkState(globalState_.available > Is it possible the get function is called before set function is called? If Done. Put Preconditions in both setter and getter. Caller must make sure to always set positive value and setter is always called before getter. http://gerrit.cloudera.org:8080/#/c/19807/7/fe/src/main/java/org/apache/impala/planner/PlanFragment.java File fe/src/main/java/org/apache/impala/planner/PlanFragment.java: http://gerrit.cloudera.org:8080/#/c/19807/7/fe/src/main/java/org/apache/impala/planner/PlanFragment.java@1093 PS7, Line 1093: if (!scanNodes.isEmpty()) { : Preconditions.checkState(scanNode > why need a loop if the expected size is not bigger than 1. Good point! Replaced it with IF. -- To view, visit http://gerrit.cloudera.org:8080/19807 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If948e45455275d9a61a6cd5d6a30a8b98a7c729a Gerrit-Change-Number: 19807 Gerrit-PatchSet: 8 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 09 May 2023 21:12:20 +0000 Gerrit-HasComments: Yes
