Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19807 )
Change subject: IMPALA-12091: Control scan parallelism by its processing cost ...................................................................... Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/19807/7/be/src/service/query-options-test.cc File be/src/service/query-options-test.cc: http://gerrit.cloudera.org:8080/#/c/19807/7/be/src/service/query-options-test.cc@262 PS7, Line 262: {MAKE_OPTIONDEF(processing_cost_min_threads), {1, 128}}, : {MAKE_OPTIONDEF(max_fragment_instances_per_node), {1, 128}}, replace 128 with new constant MAX_FRAGMENT_INSTANCES_PER_NODE http://gerrit.cloudera.org:8080/#/c/19807/7/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/19807/7/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@654 PS7, Line 654: globalState_.availableCoresPerNode_ > 0 Is it possible the get function is called before set function is called? If not, add a Preconditions.checkState(). http://gerrit.cloudera.org:8080/#/c/19807/7/fe/src/main/java/org/apache/impala/planner/PlanFragment.java File fe/src/main/java/org/apache/impala/planner/PlanFragment.java: http://gerrit.cloudera.org:8080/#/c/19807/7/fe/src/main/java/org/apache/impala/planner/PlanFragment.java@1093 PS7, Line 1093: Preconditions.checkState(scanNodes.size() <= 1); : for (ScanNode scanNode : scanNodes) why need a loop if the expected size is not bigger than 1. -- To view, visit http://gerrit.cloudera.org:8080/19807 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If948e45455275d9a61a6cd5d6a30a8b98a7c729a Gerrit-Change-Number: 19807 Gerrit-PatchSet: 7 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 09 May 2023 20:00:34 +0000 Gerrit-HasComments: Yes
