Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19660 )
Change subject: IMPALA-12019: Support ORDER BY for arrays of fixed length types in select list ...................................................................... Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/19660/9/testdata/workloads/functional-query/queries/QueryTest/top-n-parquet-orc.test File testdata/workloads/functional-query/queries/QueryTest/top-n-parquet-orc.test: http://gerrit.cloudera.org:8080/#/c/19660/9/testdata/workloads/functional-query/queries/QueryTest/top-n-parquet-orc.test@4 PS9, Line 4: order by id limit 5 there is one more case that could be tested: partitioned top n The examples I found: https://github.com/apache/impala/blob/master/testdata/workloads/functional-query/queries/QueryTest/partitioned-top-n.test https://github.com/apache/impala/blob/master/testdata/workloads/functional-query/queries/QueryTest/analytic-fns-tpcds-partitioned-topn.test I don't know whether it uses code paths that are untested at the moment, but it would be good to add some basic coverage. http://gerrit.cloudera.org:8080/#/c/19660/9/tests/query_test/test_queries.py File tests/query_test/test_queries.py: http://gerrit.cloudera.org:8080/#/c/19660/9/tests/query_test/test_queries.py@150 PS9, Line 150: self.run_test_case('QueryTest/sort-parquet-orc', vector) : self.run_test_case('QueryTest/top-n-parquet-orc', vector) nit: I think that complex or nested type is more descriptive than parquet-orc note that there are plans to add array support in Kudu -- To view, visit http://gerrit.cloudera.org:8080/19660 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic7974ef392c1412e8c60231e3420367bd189677a Gerrit-Change-Number: 19660 Gerrit-PatchSet: 9 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Mon, 15 May 2023 07:45:43 +0000 Gerrit-HasComments: Yes
