Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19898 )
Change subject: IMPALA-10186: Fix writing empty parquet page ...................................................................... Patch Set 5: Code-Review+1 (2 comments) Thanks for fixing the issue, and also simplifying the writer logic! http://gerrit.cloudera.org:8080/#/c/19898/4/be/src/util/dict-encoding.h File be/src/util/dict-encoding.h: http://gerrit.cloudera.org:8080/#/c/19898/4/be/src/util/dict-encoding.h@237 PS4, Line 237: enum { INVALID_INDEX = 40000 }; Maybe add a comment here that changing this value might need tuning tests in test_parquet_page_index.py http://gerrit.cloudera.org:8080/#/c/19898/4/tests/query_test/test_parquet_page_index.py File tests/query_test/test_parquet_page_index.py: http://gerrit.cloudera.org:8080/#/c/19898/4/tests/query_test/test_parquet_page_index.py@452 PS4, Line 452: vector Unfortunately we modify the vector all around in this file, but we should deepcopy the vector and modify the copy of it, so other tests won't be affected. -- To view, visit http://gerrit.cloudera.org:8080/19898 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I90d30d958f07c6289a1beba1b5df1ab3d7213799 Gerrit-Change-Number: 19898 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 18 May 2023 17:19:12 +0000 Gerrit-HasComments: Yes
