Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19898 )
Change subject: IMPALA-10186: Fix writing empty parquet page ...................................................................... Patch Set 6: Code-Review+2 (1 comment) Thanks, Michael! The change looks great! http://gerrit.cloudera.org:8080/#/c/19898/4/tests/query_test/test_parquet_page_index.py File tests/query_test/test_parquet_page_index.py: http://gerrit.cloudera.org:8080/#/c/19898/4/tests/query_test/test_parquet_page_index.py@452 PS4, Line 452: vector > Every test invocation gets its own version of vector via https://github.com Interesting, I vaguely remember seeing weird test errors due to not deepcopying the vector. Also, other test files have a lot of deepcopy. That said, I couldn't reproduce any errors by not deepcopying, and this file already doesn't deepcopy, so I'm OK with it. -- To view, visit http://gerrit.cloudera.org:8080/19898 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I90d30d958f07c6289a1beba1b5df1ab3d7213799 Gerrit-Change-Number: 19898 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 18 May 2023 18:23:43 +0000 Gerrit-HasComments: Yes
