Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19763 )
Change subject: IMPALA-11915: Support graphical plan and timeline exports in the WebUI ...................................................................... Patch Set 10: (1 comment) looks good to me, only a small nit. http://gerrit.cloudera.org:8080/#/c/19763/10/www/query_timeline.tmpl File www/query_timeline.tmpl: http://gerrit.cloudera.org:8080/#/c/19763/10/www/query_timeline.tmpl@563 PS10, Line 563: if(export_format.value == ".html") { nit: add a space after "if" -- To view, visit http://gerrit.cloudera.org:8080/19763 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1bd549318e220419ba3ee40be05f3671a9f1d8d9 Gerrit-Change-Number: 19763 Gerrit-PatchSet: 10 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 23 May 2023 21:42:50 +0000 Gerrit-HasComments: Yes
