Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/19763 )
Change subject: IMPALA-11915: Support graphical plan and timeline exports in the WebUI ...................................................................... Patch Set 7: (6 comments) http://gerrit.cloudera.org:8080/#/c/19763/7/www/query_plan.tmpl File www/query_plan.tmpl: http://gerrit.cloudera.org:8080/#/c/19763/7/www/query_plan.tmpl@66 PS7, Line 66: <h4 style="display:inline;"> Download (Available Formats):</h4> Change to: Download http://gerrit.cloudera.org:8080/#/c/19763/7/www/query_plan.tmpl@84 PS7, Line 84: <h5> Export Viewport </h5> change to: Download Plan http://gerrit.cloudera.org:8080/#/c/19763/7/www/query_plan.tmpl@97 PS7, Line 97: role="button"> Export </a> Change to: Download http://gerrit.cloudera.org:8080/#/c/19763/7/www/query_timeline.tmpl File www/query_timeline.tmpl: http://gerrit.cloudera.org:8080/#/c/19763/7/www/query_timeline.tmpl@40 PS7, Line 40: <h4 style="display:inline;"> Download (Available Formats):</h4> Change to: Download http://gerrit.cloudera.org:8080/#/c/19763/7/www/query_timeline.tmpl@41 PS7, Line 41: <input type="button" class="btn btn-primary" data-toggle="modal" value="SVG" Change to: HTML Like the plan export, the export should be wrapped in HTML with the query ID at the top and preserve the text styles. http://gerrit.cloudera.org:8080/#/c/19763/7/www/query_timeline.tmpl@57 PS7, Line 57: <h5> Export Timeline </h5> Change to: Download Timeline -- To view, visit http://gerrit.cloudera.org:8080/19763 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1bd549318e220419ba3ee40be05f3671a9f1d8d9 Gerrit-Change-Number: 19763 Gerrit-PatchSet: 7 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Thu, 11 May 2023 17:16:43 +0000 Gerrit-HasComments: Yes
