Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19763 )
Change subject: IMPALA-11915: Support graphical plan and timeline exports in the WebUI ...................................................................... Patch Set 9: (5 comments) In the downloaded SVG, preserve the horizontal lines between phases header and diagram, and between diagram and footer. http://gerrit.cloudera.org:8080/#/c/19763/9/www/query_timeline.tmpl File www/query_timeline.tmpl: http://gerrit.cloudera.org:8080/#/c/19763/9/www/query_timeline.tmpl@125 PS9, Line 125: { nit: add one space before { http://gerrit.cloudera.org:8080/#/c/19763/9/www/query_timeline.tmpl@139 PS9, Line 139: { nit: add one space before { http://gerrit.cloudera.org:8080/#/c/19763/9/www/query_timeline.tmpl@157 PS9, Line 157: { nit: add one space before { http://gerrit.cloudera.org:8080/#/c/19763/9/www/query_timeline.tmpl@563 PS9, Line 563: if(export_format.value == ".html"){ nit: add one space after if and add one space before { http://gerrit.cloudera.org:8080/#/c/19763/9/www/query_timeline.tmpl@587 PS9, Line 587: top_margin nit: use total_height or remove line 581. -- To view, visit http://gerrit.cloudera.org:8080/19763 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1bd549318e220419ba3ee40be05f3671a9f1d8d9 Gerrit-Change-Number: 19763 Gerrit-PatchSet: 9 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Fri, 19 May 2023 17:04:33 +0000 Gerrit-HasComments: Yes
