Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18939 )
Change subject: IMPALA-10262: RPM/DEB Packaging Support ...................................................................... Patch Set 8: (3 comments) Thank Joe's comments! I found an issue on Redhat8 when installing rpm-build. It might impact downstream builds so we'd better fix it. http://gerrit.cloudera.org:8080/#/c/18939/6/CMakeLists.txt File CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/18939/6/CMakeLists.txt@574 PS6, Line 574: : SET(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -stdlib=libstdc++") : : # packaging : if (BUILD_PACKAGES) : > I noticed recently that /etc/os-release is available on all the distributio That would be much cleaner! I just inherrit these from Shant's original patch: https://gerrit.cloudera.org/c/16612/ After some search, I found that we can use cmake_host_system_information(). DISTRIB_<name> is added since cmake-3.22. So I bump the minimal required cmake version to 3.22 accordingly. https://cmake.org/cmake/help/latest/command/cmake_host_system_information.html http://gerrit.cloudera.org:8080/#/c/18939/6/CMakeLists.txt@613 PS6, Line 613: : if ($ENV{STRIP_DEPLOYMENT_IMPALAD}) : set(CPACK_STRIP_FILES ${IMPALA_INSTALLDIR}/bin/impalad) : message("Binaries in the package will be stripped") > Ideally, this would match the docker/install_os_packages.sh logic almost ex Good point! We have the package list in several places so it'd be nice to consolidate them. For this patch, I would just avoid adding one more place for hard-coding the package list. Added a --dry-run option for docker/install_os_packages.sh to print the package list only. Java version is also included in the result. This CMake code then calls the script to get the list. http://gerrit.cloudera.org:8080/#/c/18939/7/bin/bootstrap_system.sh File bin/bootstrap_system.sh: http://gerrit.cloudera.org:8080/#/c/18939/7/bin/bootstrap_system.sh@246 PS7, Line 246: postgresql postgresql-server rpm-build \ This fails in Redhat8: # yum install -y rpm-build Last metadata expiration check: 0:05:58 ago on Mon 05 Jun 2023 04:04:45 AM PDT. Error: Problem: package rpm-build-4.14.2-11.el8_0.x86_64 requires (ansible-packaging if rpm-build), but none of the providers can be installed - package rpm-build-4.14.2-26.el8_1.x86_64 requires (ansible-packaging if rpm-build), but none of the providers can be installed - package rpm-build-4.14.2-25.el8.x86_64 requires (ansible-packaging if rpm-build), but none of the providers can be installed - package rpm-build-4.14.2-9.el8.x86_64 requires (ansible-packaging if rpm-build), but none of the providers can be installed - package rpm-build-4.14.2-10.el8_0.x86_64 requires (ansible-packaging if rpm-build), but none of the providers can be installed - package rpm-build-4.14.2-37.el8.x86_64 requires (ansible-packaging if rpm-build), but none of the providers can be installed - problem with installed package ansible-2.9.27-3.el8.noarch - cannot install the best candidate for the job - nothing provides python(abi) = 3.11 needed by ansible-7.2.0-1.el8.noarch - nothing provides python3.11dist(ansible-core) >= 2.14.2 needed by ansible-7.2.0-1.el8.noarch - nothing provides /usr/bin/python3.11 needed by ansible-7.2.0-1.el8.noarch - nothing provides ansible-core needed by ansible-packaging-1-8.2.el8.noarch -- To view, visit http://gerrit.cloudera.org:8080/18939 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64419fd400fe8d233dac016b6306157fe9461d82 Gerrit-Change-Number: 18939 Gerrit-PatchSet: 8 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Xiang Yang <[email protected]> Gerrit-Comment-Date: Mon, 05 Jun 2023 11:26:25 +0000 Gerrit-HasComments: Yes
