Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/18939 )
Change subject: IMPALA-10262: RPM/DEB Packaging Support ...................................................................... Patch Set 8: (2 comments) Thanks a lot for picking this up, Quanlong; it addresses a long-standing gap. http://gerrit.cloudera.org:8080/#/c/18939/7/bin/bootstrap_system.sh File bin/bootstrap_system.sh: http://gerrit.cloudera.org:8080/#/c/18939/7/bin/bootstrap_system.sh@246 PS7, Line 246: postgresql postgresql-server rpm-build \ > This fails in Redhat8: It would be interesting to see which exact version, release form factor (Docker image vs VM image) caused this failure. I ran some quick tests on a pretty basic (company-internal) RedHat 8.6 image (it didn't even have Git), and rpm-build installed happily. Maybe we should have a separate discussion on the mailing list to figure out the minimum Redhat8 version we want to support. http://gerrit.cloudera.org:8080/#/c/18939/8/docker/install_os_packages.sh File docker/install_os_packages.sh: http://gerrit.cloudera.org:8080/#/c/18939/8/docker/install_os_packages.sh@178 PS8, Line 178: will Nit: maybe change to 'would' ? Since this is a DRY_RUN, nothing will actually be installed, this is just a reporting exercise. Using 'will' could mislead the user. -- To view, visit http://gerrit.cloudera.org:8080/18939 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64419fd400fe8d233dac016b6306157fe9461d82 Gerrit-Change-Number: 18939 Gerrit-PatchSet: 8 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Xiang Yang <[email protected]> Gerrit-Comment-Date: Tue, 06 Jun 2023 23:06:25 +0000 Gerrit-HasComments: Yes
