Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/20009 )
Change subject: IMPALA-12183: Fix cardinality clamping across aggregation phases ...................................................................... Patch Set 2: (8 comments) http://gerrit.cloudera.org:8080/#/c/20009/2/fe/src/main/java/org/apache/impala/planner/AggregationNode.java File fe/src/main/java/org/apache/impala/planner/AggregationNode.java: http://gerrit.cloudera.org:8080/#/c/20009/2/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@238 PS2, Line 238: for (int i = 0; i < aggInfos_.size(); i++) { Please revert to the old for loop since the index is not used except to retrieve the aggInfo. http://gerrit.cloudera.org:8080/#/c/20009/2/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@263 PS2, Line 263: private long estimateNumGroups(int aggInfoIdx) { Revert this signature also http://gerrit.cloudera.org:8080/#/c/20009/2/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@307 PS2, Line 307: * Compute the input cardinality to the distributed aggregation. This search down nit:searches http://gerrit.cloudera.org:8080/#/c/20009/2/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@308 PS2, Line 308: * for the FIRST phase aggregation node, and return the minimum between input nit:returns http://gerrit.cloudera.org:8080/#/c/20009/2/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@311 PS2, Line 311: * it immediately return this node's input cardinality since output cardinality of the nit:returns http://gerrit.cloudera.org:8080/#/c/20009/2/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@542 PS2, Line 542: @Nullable AggregationNode prevAgg, int aggInfoIdx) { pass aggInfo as arg instead or idx http://gerrit.cloudera.org:8080/#/c/20009/2/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@552 PS2, Line 552: for (int i = 0; i < aggInfos_.size(); i++) { revert for loop http://gerrit.cloudera.org:8080/#/c/20009/2/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@564 PS2, Line 564: for (int i = 0; i < aggInfos_.size(); i++) { ditto. Pass aggInfo instead of i -- To view, visit http://gerrit.cloudera.org:8080/20009 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d414fe56b027f887c7f901d8a6799a388b16b95 Gerrit-Change-Number: 20009 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 06 Jun 2023 03:01:15 +0000 Gerrit-HasComments: Yes
