Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20009 )
Change subject: IMPALA-12183: Fix cardinality clamping across aggregation phases ...................................................................... Patch Set 4: (8 comments) http://gerrit.cloudera.org:8080/#/c/20009/2/fe/src/main/java/org/apache/impala/planner/AggregationNode.java File fe/src/main/java/org/apache/impala/planner/AggregationNode.java: http://gerrit.cloudera.org:8080/#/c/20009/2/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@238 PS2, Line 238: // TODO: IMPALA-2945: this doesn't correctly take into account duplicate keys on > Please revert to the old for loop since the index is not used except to ret Done http://gerrit.cloudera.org:8080/#/c/20009/2/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@263 PS2, Line 263: if (cardinality_ > 0) { > Revert this signature also Done http://gerrit.cloudera.org:8080/#/c/20009/2/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@307 PS2, Line 307: } > nit:searches Done http://gerrit.cloudera.org:8080/#/c/20009/2/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@308 PS2, Line 308: // We have a valid estimate of the number of groups. Cap it at number of input > nit:returns Done http://gerrit.cloudera.org:8080/#/c/20009/2/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@311 PS2, Line 311: numGroups = Math.min(aggInputCardinality, numGroups); > nit:returns Done http://gerrit.cloudera.org:8080/#/c/20009/2/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@542 PS2, Line 542: } > pass aggInfo as arg instead or idx Done http://gerrit.cloudera.org:8080/#/c/20009/2/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@552 PS2, Line 552: private long getAggClassInputCardinality( > revert for loop Done http://gerrit.cloudera.org:8080/#/c/20009/2/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@564 PS2, Line 564: @Override > ditto. Pass aggInfo instead of i Done -- To view, visit http://gerrit.cloudera.org:8080/20009 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d414fe56b027f887c7f901d8a6799a388b16b95 Gerrit-Change-Number: 20009 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 06 Jun 2023 18:16:32 +0000 Gerrit-HasComments: Yes
