Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20008 )
Change subject: IMPALA-12182: Add CPU utilization chart for RuntimeProfile's sampled metrics ...................................................................... Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/20008/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20008/1//COMMIT_MSG@9 PS1, Line 9: user, : sys and iowait Spell out the counter names from query profile. Also, mention that query option RESOURCE_TRACE_RATIO need to be True for the counters to show up. http://gerrit.cloudera.org:8080/#/c/20008/1//COMMIT_MSG@15 PS1, Line 15: AggregatedRuntimeProfile Is this accurate? I thought AggregatedRuntimeProfile is only used in V2 query profile. You can contrast this via startup flag. This will start minicluster with V1 profile format: ./bin/start-impala-cluster.py --impalad_args="-gen_experimental_profile=false" This will start minicluster with V2 profile format: ./bin/start-impala-cluster.py --impalad_args="-gen_experimental_profile=true" http://gerrit.cloudera.org:8080/#/c/20008/1/www/query_timeline.tmpl File www/query_timeline.tmpl: http://gerrit.cloudera.org:8080/#/c/20008/1/www/query_timeline.tmpl@559 PS1, Line 559: Whitespaces can be removed in if clause here and other places? http://gerrit.cloudera.org:8080/#/c/20008/1/www/query_timeline.tmpl@563 PS1, Line 563: summary_stats_counters[0] Can you add comment on counter names that this referring to? same as time_series_counters below and other places. http://gerrit.cloudera.org:8080/#/c/20008/1/www/query_timeline.tmpl@581 PS1, Line 581: /* Do you mind using double-slash for multiline comment? I think it will have better contrast. http://gerrit.cloudera.org:8080/#/c/20008/1/www/query_timeline.tmpl@688 PS1, Line 688: utilization_metrics_available Can we put HTML comment tag within utilization_diagram div if metrics not available? Maybe say <!--Utilization metrics is not available. Please make sure to set query option RESOURCE_TRACE_RATIO=true.--> -- To view, visit http://gerrit.cloudera.org:8080/20008 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idea2a6db217dbfaa7a0695aeabb6d9c1ecf62158 Gerrit-Change-Number: 20008 Gerrit-PatchSet: 1 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 06 Jun 2023 15:57:42 +0000 Gerrit-HasComments: Yes
