Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20008 )
Change subject: IMPALA-12182: Add CPU utilization chart for RuntimeProfile's sampled metrics ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/20008/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20008/1//COMMIT_MSG@15 PS1, Line 15: AggregatedRuntimeProfile > Please check the `SerializeToArchiveString` method in `runtime-profile.cc`, This should be RuntimeProfile instead of AggregatedRuntimeProfile. AggregatedRuntimeProfile is a different implementation of RuntimeProfileBase used only for V2 query profile format. RuntimeProfile may have ChunkedTimeSeriesCounter in its time_series_counter_map_ values. However, AggregatedRuntimeProfile will have TAggTimeSeriesCounter as its values. -- To view, visit http://gerrit.cloudera.org:8080/20008 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idea2a6db217dbfaa7a0695aeabb6d9c1ecf62158 Gerrit-Change-Number: 20008 Gerrit-PatchSet: 1 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 07 Jun 2023 17:29:57 +0000 Gerrit-HasComments: Yes
