Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20014 )
Change subject: IMPALA-11459: Use new LLVM Pass Manager ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/20014/3/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: http://gerrit.cloudera.org:8080/#/c/20014/3/be/src/codegen/llvm-codegen.cc@a1419 PS3, Line 1419: : : > Done. There wasn't really a clean point to add this in the new pass manager This didn't measurably change perf results. I'll walk through the code just to make sure the setting is being used. http://gerrit.cloudera.org:8080/#/c/20014/4/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: http://gerrit.cloudera.org:8080/#/c/20014/4/be/src/codegen/llvm-codegen.cc@1254 PS4, Line 1254: llvm::ModuleAnalysisManager module_analysis_manager; > Added back using TargetMachine from our execution engine, which gets passed This didn't measurably change the perf results from my prior run: https://jenkins.impala.io/job/perf-AB-test/438/ -- To view, visit http://gerrit.cloudera.org:8080/20014 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I947a5b067da50c18f62c3f9af9876463e542f58a Gerrit-Change-Number: 20014 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Fri, 09 Jun 2023 17:20:46 +0000 Gerrit-HasComments: Yes
