Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20014 )

Change subject: IMPALA-11459: Use new LLVM Pass Manager
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/20014/5/be/src/codegen/llvm-codegen.cc
File be/src/codegen/llvm-codegen.cc:

http://gerrit.cloudera.org:8080/#/c/20014/5/be/src/codegen/llvm-codegen.cc@157
PS5, Line 157:     "-inline-threshold=325"  // Treat all functions as having 
the inline hint
Turns out this didn't work because argv[0] is read as the process name 
:facepalm:



--
To view, visit http://gerrit.cloudera.org:8080/20014
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I947a5b067da50c18f62c3f9af9876463e542f58a
Gerrit-Change-Number: 20014
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Abhishek Rawat <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Comment-Date: Fri, 09 Jun 2023 18:45:24 +0000
Gerrit-HasComments: Yes

Reply via email to