Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20014 )
Change subject: IMPALA-11459: Use new LLVM Pass Manager ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/20014/5/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: http://gerrit.cloudera.org:8080/#/c/20014/5/be/src/codegen/llvm-codegen.cc@157 PS5, Line 157: CHECK(llvm::cl::ParseCommandLineOptions(argv.size(), argv.data())); > Turns out this didn't work because argv[0] is read as the process name :fac The run with this fixed - https://jenkins.impala.io/job/perf-AB-test/440 - has less improvement than without inline-threshold changed. So I'm not sure this is worth retaining. -- To view, visit http://gerrit.cloudera.org:8080/20014 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I947a5b067da50c18f62c3f9af9876463e542f58a Gerrit-Change-Number: 20014 Gerrit-PatchSet: 7 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Fri, 09 Jun 2023 22:32:29 +0000 Gerrit-HasComments: Yes
