Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/20077 )
Change subject: IMPALA-11013: Support 'MIGRATE TABLE' for external HDFS tables ...................................................................... Patch Set 5: (4 comments) Looks nice! Marked some recovery options if a sub-query fails. http://gerrit.cloudera.org:8080/#/c/20077/5/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/20077/5/be/src/service/client-request-state.cc@2269 PS5, Line 2269: } I think we should try to revert the table name if the query status is not ok. http://gerrit.cloudera.org:8080/#/c/20077/5/be/src/service/client-request-state.cc@2313 PS5, Line 2313: { We should notify the user in case the query status is not ok if the clean up part fails. http://gerrit.cloudera.org:8080/#/c/20077/5/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java File fe/src/main/java/org/apache/impala/catalog/IcebergTable.java: http://gerrit.cloudera.org:8080/#/c/20077/5/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@136 PS5, Line 136: public static final String METADATA_FOLDER_NAME = "metadata"; nit: this way it gives the impression that the above comment is related http://gerrit.cloudera.org:8080/#/c/20077/5/fe/src/main/java/org/apache/impala/util/MigrateTableUtil.java File fe/src/main/java/org/apache/impala/util/MigrateTableUtil.java: http://gerrit.cloudera.org:8080/#/c/20077/5/fe/src/main/java/org/apache/impala/util/MigrateTableUtil.java@60 PS5, Line 60: nit: comment -- To view, visit http://gerrit.cloudera.org:8080/20077 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iacdad996d680fe545cc9a45e6bc64a348a64cd80 Gerrit-Change-Number: 20077 Gerrit-PatchSet: 5 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 21 Jun 2023 08:24:39 +0000 Gerrit-HasComments: Yes
