[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/20077 )
Change subject: IMPALA-11013: Support 'MIGRATE TABLE' for external Hive tables ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/20077/5/fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java File fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java: http://gerrit.cloudera.org:8080/#/c/20077/5/fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java@138 PS5, Line 138: .table(table.getFullName()) > It is verified in L90. Done http://gerrit.cloudera.org:8080/#/c/20077/5/fe/src/main/java/org/apache/impala/util/MigrateTableUtil.java File fe/src/main/java/org/apache/impala/util/MigrateTableUtil.java: http://gerrit.cloudera.org:8080/#/c/20077/5/fe/src/main/java/org/apache/impala/util/MigrateTableUtil.java@235 PS5, Line 235: Math.min > I find it a bit dangerous to default to the number of CPU cores because the No problem, it's safer and can also increase concurrency with query option. BTW: We should make sure that this "query option logic" is clear to Impala users in the official doc. -- To view, visit http://gerrit.cloudera.org:8080/20077 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iacdad996d680fe545cc9a45e6bc64a348a64cd80 Gerrit-Change-Number: 20077 Gerrit-PatchSet: 5 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 28 Jun 2023 02:30:52 +0000 Gerrit-HasComments: Yes
