Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/20077 )
Change subject: IMPALA-11013: Support 'MIGRATE TABLE' for external Hive tables ...................................................................... Patch Set 6: Code-Review+1 (2 comments) LGTM! You had some answers to Zoltan, so I am only giving +1 as well. http://gerrit.cloudera.org:8080/#/c/20077/5/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/20077/5/be/src/service/client-request-state.cc@2313 PS5, Line 2313: unique_ptr<ChildQueryExecutor> query_executor(new ChildQueryExecutor()); > L2315 is responsible for notifying the user about such failures. I am having concerns if a user would understand a DROP table query failure after issuing MIGRATE statement. But we can go with this for now. http://gerrit.cloudera.org:8080/#/c/20077/6/fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java File fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java: http://gerrit.cloudera.org:8080/#/c/20077/6/fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java@108 PS6, Line 108: nit: empty line -- To view, visit http://gerrit.cloudera.org:8080/20077 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iacdad996d680fe545cc9a45e6bc64a348a64cd80 Gerrit-Change-Number: 20077 Gerrit-PatchSet: 6 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 28 Jun 2023 09:08:21 +0000 Gerrit-HasComments: Yes
