Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20014 )
Change subject: IMPALA-11459: Use new LLVM Pass Manager ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/20014/8/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: http://gerrit.cloudera.org:8080/#/c/20014/8/be/src/codegen/llvm-codegen.cc@156 PS8, Line 156: std::array<const char*, 2> argv = { procname, "-inline-threshold=325" }; > I don't think we should keep this. I can't reproduce the improvement mentio However I can try removing it as a separate patch so we can get a clearer AB test run on it. -- To view, visit http://gerrit.cloudera.org:8080/20014 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I947a5b067da50c18f62c3f9af9876463e542f58a Gerrit-Change-Number: 20014 Gerrit-PatchSet: 8 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Thu, 22 Jun 2023 18:54:30 +0000 Gerrit-HasComments: Yes
