Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19863 )
Change subject: IMPALA-11941: Support Java 17 in Impala ...................................................................... Patch Set 27: (2 comments) http://gerrit.cloudera.org:8080/#/c/19863/27/be/src/common/init.cc File be/src/common/init.cc: http://gerrit.cloudera.org:8080/#/c/19863/27/be/src/common/init.cc@106 PS27, Line 106: DEFINE_bool_hidden(use_jamm_weigher, true, Jamm seems to have a regression compared to SizeOf on Java 8. There's a patch to fix it - https://github.com/jbellis/jamm/pull/57 - but it might be safer to select implementation based on Java version. We could have an adaptive default that uses SizeOf with Java 8 and 11, and Jamm for 17. http://gerrit.cloudera.org:8080/#/c/19863/27/be/src/common/init.cc@326 PS27, Line 326: jamm_path = FileSystemUtil::FindFileInPath(test_path, "jamm-.*.jar"); > Optional: We might need to handle wildcards in the CLASSPATH, e.g. fe/targe Ah. That seems to specify all files in that directory. So stripping off trailing wildcard character might be sufficient. -- To view, visit http://gerrit.cloudera.org:8080/19863 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic378896f572e030a3a019646a96a32a07866a737 Gerrit-Change-Number: 19863 Gerrit-PatchSet: 27 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 23 Jun 2023 14:33:49 +0000 Gerrit-HasComments: Yes
