Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19863 )
Change subject: IMPALA-11941: Support Java 17 in Impala ...................................................................... Patch Set 29: (1 comment) http://gerrit.cloudera.org:8080/#/c/19863/29/be/src/common/init.cc File be/src/common/init.cc: http://gerrit.cloudera.org:8080/#/c/19863/29/be/src/common/init.cc@315 PS29, Line 315: static int GetJavaMajorVersion() { > And handle the defaulting outside this method? That makes sense, went back Or wrap it in RETURN_IF_ERROR and fail startup if we can't figure out the Java version. I'm on the fence, and I don't have a strong preference here. If we want to tolerate it, then the code is fine as-is. -- To view, visit http://gerrit.cloudera.org:8080/19863 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic378896f572e030a3a019646a96a32a07866a737 Gerrit-Change-Number: 19863 Gerrit-PatchSet: 29 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 23 Jun 2023 18:44:08 +0000 Gerrit-HasComments: Yes
