Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19863 )
Change subject: IMPALA-11941: Support Java 17 in Impala ...................................................................... Patch Set 29: Code-Review+1 (1 comment) I think the new behavior of using ehcache for Java 8 / 11 and using jamm for Java 17 makes sense. As we get more confidence in jamm and get an official release, we can switch those over. We know jamm is better on Java 17. http://gerrit.cloudera.org:8080/#/c/19863/29/be/src/common/init.cc File be/src/common/init.cc: http://gerrit.cloudera.org:8080/#/c/19863/29/be/src/common/init.cc@315 PS29, Line 315: static int GetJavaMajorVersion() { Nit: I think it is ok to default to Java 8 rather than failing (because that makes it like our historical behavior), but an alternative is to have a signature like: static Status GetJavaMajorVersion(int* version); -- To view, visit http://gerrit.cloudera.org:8080/19863 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic378896f572e030a3a019646a96a32a07866a737 Gerrit-Change-Number: 19863 Gerrit-PatchSet: 29 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 23 Jun 2023 18:28:06 +0000 Gerrit-HasComments: Yes
