ttttttz has posted comments on this change. ( http://gerrit.cloudera.org:8080/19878 )
Change subject: IMPALA-12131: For non-partitioned tables, defer the resetPartitions() until the file metadata is loaded. ...................................................................... Patch Set 20: (4 comments) Thanks Quanlong! http://gerrit.cloudera.org:8080/#/c/19878/19//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19878/19//COMMIT_MSG@9 PS19, Line 9: When inserting non-partitioned tables, the catalog update : request could fail due to file not found exceptions. At that : point we have reset(cleared) the partition map so it becomes : empty after the failure, which is an illegal state and will > We'd better refine this long sentence, e.g. Ack http://gerrit.cloudera.org:8080/#/c/19878/19//COMMIT_MSG@13 PS19, Line 13: cause failures in later operations. Currently, users have to : manually invalidate the me > "Currently, users have to manually invalidate the metadata of the table to Ack http://gerrit.cloudera.org:8080/#/c/19878/19//COMMIT_MSG@14 PS19, Line 14: adata of the table to recover. We : can improve this by making all the updates happen after > "We can improve this by making all the updates happen after all the externa Ack http://gerrit.cloudera.org:8080/#/c/19878/19/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/19878/19/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@1397 PS19, Line 1397: // Step 2: update internal fields > nit: setUnpartitionedTableStats() also updates internal fields. Please move Ack -- To view, visit http://gerrit.cloudera.org:8080/19878 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I28e76a73b7905c24eb93b935124d20ea7abe8513 Gerrit-Change-Number: 19878 Gerrit-PatchSet: 20 Gerrit-Owner: ttttttz <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Manish Maheshwari <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: ttttttz <[email protected]> Gerrit-Comment-Date: Tue, 27 Jun 2023 03:03:17 +0000 Gerrit-HasComments: Yes
