Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19878 )
Change subject: IMPALA-12131: For non-partitioned tables, defer the resetPartitions() until the file metadata is loaded. ...................................................................... Patch Set 23: (2 comments) http://gerrit.cloudera.org:8080/#/c/19878/23//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19878/23//COMMIT_MSG@7 PS23, Line 7: IMPALA-12131: For non-partitioned tables, defer the resetPartitions() until the file metadata is loaded. The title might be too detailed, maybe this is better: "Fix empty partition map in non-partitioned table when file metadata loading fails" http://gerrit.cloudera.org:8080/#/c/19878/23/tests/query_test/test_insert.py File tests/query_test/test_insert.py: http://gerrit.cloudera.org:8080/#/c/19878/23/tests/query_test/test_insert.py@215 PS23, Line 215: def test_unpartition_insert(self, vector, unique_database): I realized this test will run in several dimensions, especially in exhaustive strategy. We don't actually create table in different formats. So it'd be nice to extract this into an individual test class, e.g. TestInsertNonPartitionedTable. BTW, we don't need the sync_ddl=True annotation since we just connect to one impalad. -- To view, visit http://gerrit.cloudera.org:8080/19878 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I28e76a73b7905c24eb93b935124d20ea7abe8513 Gerrit-Change-Number: 19878 Gerrit-PatchSet: 23 Gerrit-Owner: ttttttz <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Manish Maheshwari <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: ttttttz <[email protected]> Gerrit-Comment-Date: Wed, 28 Jun 2023 08:26:26 +0000 Gerrit-HasComments: Yes
