Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/20077 )
Change subject: IMPALA-11013: Support 'MIGRATE TABLE' for external Hive tables ...................................................................... Patch Set 7: (8 comments) http://gerrit.cloudera.org:8080/#/c/20077/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20077/5//COMMIT_MSG@11 PS5, Line 11: a non-transaction > Hive 3 defined external tables as non-transactional tables. I personally do Understood. I'll remove the 'external' pre-condition from the commit message, but leave the check in the code. http://gerrit.cloudera.org:8080/#/c/20077/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20077/6//COMMIT_MSG@36 PS6, Line 36: > Please mention that it is a query option, and what is the default value. Done http://gerrit.cloudera.org:8080/#/c/20077/5/fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java File fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java: http://gerrit.cloudera.org:8080/#/c/20077/5/fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java@90 PS5, Line 90: : if (table.getMetaStoreTable().getParameters() != null && : AcidUtils.isTransactionalTable(table.getMetaStoreTable().getParameters())) { : throw new AnalysisException( : "CONVERT TO ICEBERG is not supported for transactional tables"); : } : : if (!MetaStoreUtils.isExternalTable(table.getMetaStoreTable())) { : throw new AnalysisException( : > Not necessarily. I can run an ALTER TABLE to change 'EXTERNAL' property to As discussed, I'll keep both but will swap the order of these checks. http://gerrit.cloudera.org:8080/#/c/20077/6/fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java File fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java: http://gerrit.cloudera.org:8080/#/c/20077/6/fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java@108 PS6, Line 108: if (properties_.size() > 1 || > nit: empty line Done http://gerrit.cloudera.org:8080/#/c/20077/5/fe/src/main/java/org/apache/impala/util/MigrateTableUtil.java File fe/src/main/java/org/apache/impala/util/MigrateTableUtil.java: http://gerrit.cloudera.org:8080/#/c/20077/5/fe/src/main/java/org/apache/impala/util/MigrateTableUtil.java@235 PS5, Line 235: > No problem, it's safer and can also increase concurrency with query option. Sure. Once the code is merged I plan to take care of the docs update. http://gerrit.cloudera.org:8080/#/c/20077/6/fe/src/main/java/org/apache/impala/util/MigrateTableUtil.java File fe/src/main/java/org/apache/impala/util/MigrateTableUtil.java: http://gerrit.cloudera.org:8080/#/c/20077/6/fe/src/main/java/org/apache/impala/util/MigrateTableUtil.java@201 PS6, Line 201: importDataFilesImpl > Currently we are processing partitions one-by-one, paralellizing the file p Good idea! Opened a Jira for this: https://issues.apache.org/jira/browse/IMPALA-12251 http://gerrit.cloudera.org:8080/#/c/20077/6/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/20077/6/tests/authorization/test_ranger.py@1966 PS6, Line 1966: # Grant ALL privileges on the table for non-admin user. Even with this the query : # should fail. > If we expect it to work in the future, do we have a Jira for this? And can There is a Jira for fixing the root cause (when table-level privileges are lost after renaming a table). I linked it here. http://gerrit.cloudera.org:8080/#/c/20077/6/tests/authorization/test_ranger.py@1979 PS6, Line 1979: self.execute_query_expect_success( : non_admin_client, "alter table {0} convert to iceberg".format(tbl_name), : user=user) > Can we add another statement to verify it is an Iceberg table? E.g. DESCRIB Done -- To view, visit http://gerrit.cloudera.org:8080/20077 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iacdad996d680fe545cc9a45e6bc64a348a64cd80 Gerrit-Change-Number: 20077 Gerrit-PatchSet: 7 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 28 Jun 2023 13:58:30 +0000 Gerrit-HasComments: Yes
