Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20143 )
Change subject: IMPALA-11941: (Addendum) ease testing other JDKs ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/20143/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20143/5//COMMIT_MSG@15 PS5, Line 15: different JDK than it originally started with. We have some custom-cluster tests that will restart Hive. Should we make sure the original JDK is used? https://github.com/apache/impala/blob/d52edc5e425b50f0b59ec1f8cc10698eb8f4282e/tests/authorization/test_ranger.py#L1939 https://github.com/apache/impala/blob/d52edc5e425b50f0b59ec1f8cc10698eb8f4282e/tests/custom_cluster/test_catalog_hms_failures.py#L49 http://gerrit.cloudera.org:8080/#/c/20143/5/fe/src/test/java/org/apache/impala/customservice/KuduHMSIntegrationTest.java File fe/src/test/java/org/apache/impala/customservice/KuduHMSIntegrationTest.java: http://gerrit.cloudera.org:8080/#/c/20143/5/fe/src/test/java/org/apache/impala/customservice/KuduHMSIntegrationTest.java@53 PS5, Line 53: return; I'm confused how the tests pass if they depend on Kudu running with HMS integration. Should we skip the test? -- To view, visit http://gerrit.cloudera.org:8080/20143 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I46b5515efd9537d63b843dbc42aa93b376efce00 Gerrit-Change-Number: 20143 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 05 Jul 2023 00:14:20 +0000 Gerrit-HasComments: Yes
