Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20143 )
Change subject: IMPALA-11941: (Addendum) ease testing other JDKs ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/20143/5/fe/src/test/java/org/apache/impala/customservice/KuduHMSIntegrationTest.java File fe/src/test/java/org/apache/impala/customservice/KuduHMSIntegrationTest.java: http://gerrit.cloudera.org:8080/#/c/20143/5/fe/src/test/java/org/apache/impala/customservice/KuduHMSIntegrationTest.java@53 PS5, Line 53: return; > Ack Maybe we can use Assume.assumeTrue() to skip it? E.g. https://github.com/apache/impala/blob/7ca11dfc7fc26646f2e7194be74ba9739ea842bf/fe/src/test/java/org/apache/impala/catalog/CatalogTest.java#L812 https://github.com/apache/impala/blob/bb7ad61c6c381ac25cd3fa198944230799fb8be8/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java#L826 -- To view, visit http://gerrit.cloudera.org:8080/20143 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I46b5515efd9537d63b843dbc42aa93b376efce00 Gerrit-Change-Number: 20143 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 12 Jul 2023 02:45:00 +0000 Gerrit-HasComments: Yes
