Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20143 )
Change subject: IMPALA-11941: (Addendum) ease testing other JDKs ...................................................................... Patch Set 6: (1 comment) A more complicated approach is to maintain two sets of Java environment variables. One set is for running Impala /tests. The other set is for everything else (build, minicluster, etc). Both would get set in bin/impala-config.sh with independent knobs. The individual scripts would be responsible for setting JAVA_HOME/LD_LIBRARY_PATH appropriately. bin/run-jvm-binary.sh would use the test-specific JAVA_HOME (and set LD_LIBRARY_PATH accordingly). The surefire fe test invocation would have to respect it as well. Minicluster components would use the regular java path. To really be disciplined about it, setting JAVA_HOME=unusable in bin/impala-config.sh might force every script to explicitly set JAVA_HOME from one of the two sources. This can be a separate JIRA. It would take some work to smoke out the JAVA_HOME locations. http://gerrit.cloudera.org:8080/#/c/20143/6/bin/run-all-tests.sh File bin/run-all-tests.sh: http://gerrit.cloudera.org:8080/#/c/20143/6/bin/run-all-tests.sh@35 PS6, Line 35: # Use a different JDK for testing. Picked up by impala-config and start-impala-cluster. : if [ ! -z "${TEST_JAVA_HOME_OVERRIDE:-}" ]; then : export IMPALA_JAVA_HOME_OVERRIDE="${TEST_JAVA_HOME_OVERRIDE}" : elif [ ! -z "${TEST_JDK_VERSION:-}" ]; then : export IMPALA_JDK_VERSION="${TEST_JDK_VERSION}" : fi The steps to test locally would be: 1. Build normally 2. Make sure the minicluster is started 3. Set IMPALA_JAVA_HOME_OVERRIDE or IMPALA_JDK_VERSION 4. Set TEST_JAVA_HOME_OVERRIDE or TEST_JDK_VERSION 5. source bin/impala-config.sh again. 6. Run tests normally (but don't rebuild) -- To view, visit http://gerrit.cloudera.org:8080/20143 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I46b5515efd9537d63b843dbc42aa93b376efce00 Gerrit-Change-Number: 20143 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 12 Jul 2023 20:26:48 +0000 Gerrit-HasComments: Yes
