Yida Wu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20211
Change subject: IMPALA-12253: Improve the integration of codegen cache and async codegen ...................................................................... IMPALA-12253: Improve the integration of codegen cache and async codegen To improve the integration of codegen cache and async codegen, the seperate the FinalizeModule() into two parts, PrepareFinalizeModule() and FinalizeModule(). If codegen cache enabled, PrepareFinalizeModule() would generate the key of the module, so that if there is a cache hit, we could skip the FinalizeModule() no matter in async or sync. Otherwise, if the cache misses, we would keep going and call FinalizeModule() to finish the compilation of the module. This helps the codegen cache to have the advantage of async codegen for the first visit while reducing the need of creating new threads for async codegen if cache exists. Did the perf a-b test with async codegen and codegen cache enabled, didn't see any significant performance regression. Change-Id: Ic5ae4b342ff8ef1c3b7ce35c927baa8b59d72908 --- M be/src/benchmarks/expr-benchmark.cc M be/src/benchmarks/hash-benchmark.cc M be/src/codegen/llvm-codegen-cache-test.cc M be/src/codegen/llvm-codegen-test.cc M be/src/codegen/llvm-codegen.cc M be/src/codegen/llvm-codegen.h M be/src/exprs/expr-codegen-test.cc M be/src/runtime/fragment-state.cc M be/src/service/fe-support.cc 9 files changed, 80 insertions(+), 19 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/11/20211/1 -- To view, visit http://gerrit.cloudera.org:8080/20211 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic5ae4b342ff8ef1c3b7ce35c927baa8b59d72908 Gerrit-Change-Number: 20211 Gerrit-PatchSet: 1 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]>
