Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20211 )
Change subject: IMPALA-12253: Improve the integration of codegen cache and async codegen ...................................................................... Patch Set 2: I can't see that 'bool disable_codegen_cache_' be/src/runtime/query-state.h is ever set to anything but 'false', maybe we can remove that variable? -- To view, visit http://gerrit.cloudera.org:8080/20211 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5ae4b342ff8ef1c3b7ce35c927baa8b59d72908 Gerrit-Change-Number: 20211 Gerrit-PatchSet: 2 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 23 Aug 2023 14:07:18 +0000 Gerrit-HasComments: No
