Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20211 )
Change subject: IMPALA-12253: Improve the integration of codegen cache and async codegen ...................................................................... Patch Set 1: (5 comments) Overall makes sense. http://gerrit.cloudera.org:8080/#/c/20211/1/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: http://gerrit.cloudera.org:8080/#/c/20211/1/be/src/codegen/llvm-codegen.cc@1384 PS1, Line 1384: DCHECK(cache_key_ != nullptr && !cache_key_->empty()); nit: https://en.cppreference.com/w/cpp/memory/unique_ptr/operator_bool is equivalent. http://gerrit.cloudera.org:8080/#/c/20211/1/be/src/codegen/llvm-codegen.cc@1386 PS1, Line 1386: store_cache_status = StoreCache(*(cache_key_.get())); nit: https://en.cppreference.com/w/cpp/memory/unique_ptr/operator* is equivalent. Also applies to line 1341. http://gerrit.cloudera.org:8080/#/c/20211/1/be/src/runtime/fragment-state.cc File be/src/runtime/fragment-state.cc: http://gerrit.cloudera.org:8080/#/c/20211/1/be/src/runtime/fragment-state.cc@128 PS1, Line 128: bool can_return = false; Why initialize can_return here but not in fe-support.cc? Seems inconsistent. http://gerrit.cloudera.org:8080/#/c/20211/1/be/src/runtime/fragment-state.cc@139 PS1, Line 139: RETURN_IF_ERROR(llvm_codegen->FinalizeModuleAsync(event_sequence)); Is there some sort of test we could add that FinalizeModule and FinalizeModuleAsync are skipped on a cache hit? http://gerrit.cloudera.org:8080/#/c/20211/1/be/src/service/fe-support.cc File be/src/service/fe-support.cc: http://gerrit.cloudera.org:8080/#/c/20211/1/be/src/service/fe-support.cc@247 PS1, Line 247: status = codegen->FinalizeModule(); Maybe DCHECK(status.ok()) here. -- To view, visit http://gerrit.cloudera.org:8080/20211 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5ae4b342ff8ef1c3b7ce35c927baa8b59d72908 Gerrit-Change-Number: 20211 Gerrit-PatchSet: 1 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 18 Jul 2023 18:20:11 +0000 Gerrit-HasComments: Yes
