Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20204 )
Change subject: IMPALA-12072: Include snapshot id of Iceberg tables in query plan / profile ...................................................................... Patch Set 7: -Code-Review The problem is that table.snapshotId() returns -1 at https://github.com/apache/impala/blob/e38bc96b49d05a15464d174336ea6b21ffb04f5e/fe/src/main/java/org/apache/impala/util/IcebergUtil.java#L592 One quick fix would be to only invoke IcebergUtil.getSnapshotId() in IcebergScanPlanner when tblRef_.getTimeTravelSpec() is not null. -- To view, visit http://gerrit.cloudera.org:8080/20204 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee0b4967429ea733729ad8e44df32e3b24b88525 Gerrit-Change-Number: 20204 Gerrit-PatchSet: 7 Gerrit-Owner: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 31 Jul 2023 14:27:53 +0000 Gerrit-HasComments: No
