Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20399 )
Change subject: IMPALA-5081: Add codegen_opt_level query option ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/20399/1/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: http://gerrit.cloudera.org:8080/#/c/20399/1/be/src/codegen/llvm-codegen.cc@1409 PS1, Line 1409: switch (optLevel) { > Tests of flags that are accepted could make sense. I'm not sure there are c Would it make sense to log the optimisation level in the profile (or in the INFO log)? http://gerrit.cloudera.org:8080/#/c/20399/1/common/thrift/ImpalaService.thrift File common/thrift/ImpalaService.thrift: http://gerrit.cloudera.org:8080/#/c/20399/1/common/thrift/ImpalaService.thrift@837 PS1, Line 837: Has no effect on cached : // codegen entries Do you think it would be worthwhile to make it possible to force clearing the cache without restarting Impala (in a separate commit)? -- To view, visit http://gerrit.cloudera.org:8080/20399 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I371f8758b6552263e91a1fbfd9a6e1c28e1fa2bd Gerrit-Change-Number: 20399 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 23 Aug 2023 12:37:55 +0000 Gerrit-HasComments: Yes
