Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20399 )
Change subject: IMPALA-5081: Add codegen_opt_level query option ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/20399/1/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: http://gerrit.cloudera.org:8080/#/c/20399/1/be/src/codegen/llvm-codegen.cc@1409 PS1, Line 1409: switch (optLevel) { > As far as I know, non-default Query Options are visible in the profile. Yes, it shows up in the query profile. I was thinking more along the lines of verifying that we're actually optimizing at different levels. llvm::PassBuilder::OptimizationLevel doesn't have a string representation. I think the profile list of non-default query options is sufficient as feedback. http://gerrit.cloudera.org:8080/#/c/20399/1/common/thrift/ImpalaService.thrift File common/thrift/ImpalaService.thrift: http://gerrit.cloudera.org:8080/#/c/20399/1/common/thrift/ImpalaService.thrift@837 PS1, Line 837: Has no effect on cached : // codegen entries > Do you think it would be worthwhile to make it possible to force clearing t Yida and I were discussing this in JIRA. That's another option we didn't mention. This is somewhat experimental, I suggested making improvements to the workflow if it shows promising results. It is possible to exclude a query from the cache while experimenting with disable_codegen_cache, but that requires forethought. -- To view, visit http://gerrit.cloudera.org:8080/20399 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I371f8758b6552263e91a1fbfd9a6e1c28e1fa2bd Gerrit-Change-Number: 20399 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 23 Aug 2023 16:35:25 +0000 Gerrit-HasComments: Yes
