Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20399 )
Change subject: IMPALA-5081: Add codegen_opt_level query option ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/20399/2/be/src/codegen/llvm-codegen-cache.h File be/src/codegen/llvm-codegen-cache.h: http://gerrit.cloudera.org:8080/#/c/20399/2/be/src/codegen/llvm-codegen-cache.h@166 PS2, Line 166: void Init() { memset((uint8_t*)this, 0, sizeof(CodeGenCacheEntry)); } > Not relevant to this change but wouldn't it be better to call Reset() here I don't see any problem with changing to that. I'll let Yida weigh in though. http://gerrit.cloudera.org:8080/#/c/20399/2/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: http://gerrit.cloudera.org:8080/#/c/20399/2/be/src/codegen/llvm-codegen.cc@1448 PS2, Line 1448: > Nit: unneeded space. This is multiplication and preserves the prior formatting. Pretty sure code formatter would complain if I removed the space. http://gerrit.cloudera.org:8080/#/c/20399/2/common/thrift/ImpalaService.thrift File common/thrift/ImpalaService.thrift: http://gerrit.cloudera.org:8080/#/c/20399/2/common/thrift/ImpalaService.thrift@845 PS2, Line 845: O1, Os, O2, or O3 > O0 is also a possibility. Ack http://gerrit.cloudera.org:8080/#/c/20399/2/common/thrift/ImpalaService.thrift@846 PS2, Line 846: Defaults to O2. > If we ever change the default value we'll probably forget this comment. The This is a pattern we use a lot of other places here. I'm amenable to this argument however. -- To view, visit http://gerrit.cloudera.org:8080/20399 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I371f8758b6552263e91a1fbfd9a6e1c28e1fa2bd Gerrit-Change-Number: 20399 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 24 Aug 2023 16:43:47 +0000 Gerrit-HasComments: Yes
