Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20366 )
Change subject: IMPALA-12357: Skip scheduling bloom filter from full-build scan ...................................................................... Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/20366/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20366/6//COMMIT_MSG@23 PS6, Line 23: : 3. The planned bloom filter has resulting fpp estimate highe > can you mention the query option? Done http://gerrit.cloudera.org:8080/#/c/20366/6/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java File fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java: http://gerrit.cloudera.org:8080/#/c/20366/6/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@843 PS6, Line 843: private boolean hasIncomingFilter_ = false; > nit: would prefer returning early for < 0 case to reduce nesting Done http://gerrit.cloudera.org:8080/#/c/20366/6/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@859 PS6, Line 859: public void reset() { > What would happen with nodes where there is also a right child, for example Make sense. Changed the checking to use visitor instead. -- To view, visit http://gerrit.cloudera.org:8080/20366 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I494533bc06da84e606cbd1ae1619083333089a5e Gerrit-Change-Number: 20366 Gerrit-PatchSet: 7 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 29 Aug 2023 22:14:54 +0000 Gerrit-HasComments: Yes
