David Rorke has posted comments on this change. ( http://gerrit.cloudera.org:8080/20366 )
Change subject: IMPALA-12357: Skip scheduling bloom filter from full-build scan ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/20366/9/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java File fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java: http://gerrit.cloudera.org:8080/#/c/20366/9/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@892 PS9, Line 892: && f.est_fpp_ > maxAllowedFpp) At this point I agree it makes sense to require both FK/PK and high FPP to eliminate the filter. FK/PK alone may not be enough to justify eliminating the filter because you could end up eliminating a filter that is effective because it filters a lot of NULLs. But if we were to implement IMPALA-2743 at some point in the future then the null filtering might be covered by that, and we might find then that we want to drop a filter if it fails either the FK/PK check or the FPP check (instead of requiring both). Maybe we should put a TODO here to remind us to revisit this if and when we do IMPALA-2743? -- To view, visit http://gerrit.cloudera.org:8080/20366 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I494533bc06da84e606cbd1ae1619083333089a5e Gerrit-Change-Number: 20366 Gerrit-PatchSet: 9 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 31 Aug 2023 20:06:54 +0000 Gerrit-HasComments: Yes
