Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/20366 )
Change subject: IMPALA-12357: Skip scheduling bloom filter from full-build scan ...................................................................... Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/20366/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20366/7//COMMIT_MSG@26 PS7, Line 26: One more thing that comes to mind is having stats on the table - what will happen without stats, will Impala compute fpp based on wild estimates? Though the case without stats seems secondary, I can imagine this as potential source of regression, as the filter created based on a table without stats may be actually selective. http://gerrit.cloudera.org:8080/#/c/20366/6/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java File fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java: http://gerrit.cloudera.org:8080/#/c/20366/6/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@859 PS6, Line 859: public void reset() { > Make sense. Changed the checking to use visitor instead. What happens if other nodes also have predicates? An example that comes to mind is unnesting collections - the nested loop join that creates the root tuple + collection tuple pairs can have predicates that use columns from both tuple. Maybe this could be simplifies by having a white list of nodes that the fragment can contain to apply this pruning. The commit message also suggests that we don't support other nodes than scan "1. Build side is full table scan" Another thing is that having a few tests with more complex fragments would be nice. http://gerrit.cloudera.org:8080/#/c/20366/7/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java File fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java: http://gerrit.cloudera.org:8080/#/c/20366/7/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@838 PS7, Line 838: is nit: "there exists" -- To view, visit http://gerrit.cloudera.org:8080/20366 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I494533bc06da84e606cbd1ae1619083333089a5e Gerrit-Change-Number: 20366 Gerrit-PatchSet: 7 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 30 Aug 2023 05:43:52 +0000 Gerrit-HasComments: Yes
