Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20366 )
Change subject: IMPALA-12357: Skip scheduling bloom filter from full-build scan ...................................................................... Patch Set 15: (4 comments) http://gerrit.cloudera.org:8080/#/c/20366/13/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java File fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java: http://gerrit.cloudera.org:8080/#/c/20366/13/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@862 PS13, Line 862: ar > nit: are Done http://gerrit.cloudera.org:8080/#/c/20366/13/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@881 PS13, Line 881: AfterExchange().h > I don't get it - why do we have access to this protected member? RuntimeFilterGenerator and PlanNode is in the same package: org.apache.impala.planner http://gerrit.cloudera.org:8080/#/c/20366/13/fe/src/main/java/org/apache/impala/planner/ScanNode.java File fe/src/main/java/org/apache/impala/planner/ScanNode.java: http://gerrit.cloudera.org:8080/#/c/20366/13/fe/src/main/java/org/apache/impala/planner/ScanNode.java@95 PS13, Line 95: hasHardEstimates_ > Maybe one more thing that could be checked is that there is only one tuple Added !isAccessingCollectionType() check, and test case with complex type build scan. http://gerrit.cloudera.org:8080/#/c/20366/13/testdata/workloads/functional-planner/queries/PlannerTest/bloom-filter-assignment.test File testdata/workloads/functional-planner/queries/PlannerTest/bloom-filter-assignment.test: http://gerrit.cloudera.org:8080/#/c/20366/13/testdata/workloads/functional-planner/queries/PlannerTest/bloom-filter-assignment.test@553 PS13, Line 553: hosts=1 > I see that the host number is always 1 in this file - does that mean that t Good point! Fixed the bug with ExchangeNode and add DISTRIBUTEDPLAN section. -- To view, visit http://gerrit.cloudera.org:8080/20366 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I494533bc06da84e606cbd1ae1619083333089a5e Gerrit-Change-Number: 20366 Gerrit-PatchSet: 15 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 07 Sep 2023 22:48:17 +0000 Gerrit-HasComments: Yes
