Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20366 )
Change subject: IMPALA-12357: Skip scheduling bloom filter from full-build scan ...................................................................... Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/20366/11/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java File fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java: http://gerrit.cloudera.org:8080/#/c/20366/11/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@842 PS11, Line 842: private boolean hasIncomingFilter_ = false; : : @Override > hasScanConjuct_ and hasIneligiblePlanNode_ could be also calculated before Great idea! Added PlanNode.hasHardEstimate_ in patch set 12. Thanks! http://gerrit.cloudera.org:8080/#/c/20366/11/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@863 PS11, Line 863: > The name could be more descriptive, e.g. isEligibleForPruning Done -- To view, visit http://gerrit.cloudera.org:8080/20366 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I494533bc06da84e606cbd1ae1619083333089a5e Gerrit-Change-Number: 20366 Gerrit-PatchSet: 12 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 07 Sep 2023 17:42:00 +0000 Gerrit-HasComments: Yes
