Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/20366 )
Change subject: IMPALA-12357: Skip scheduling bloom filter from full-build scan ...................................................................... Patch Set 11: Code-Review+1 (2 comments) lgtm in general, though I would prefer to move some calculations earlier in the planning http://gerrit.cloudera.org:8080/#/c/20366/11/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java File fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java: http://gerrit.cloudera.org:8080/#/c/20366/11/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@842 PS11, Line 842: private boolean hasScanConjuct_ = false; : private boolean hasIncomingFilter_ = false; : private boolean hasIneligiblePlanNode_ = false; hasScanConjuct_ and hasIneligiblePlanNode_ could be also calculated before runtime filter generation, e.g. during PlanNode.computeStats() (both can be true if they are true for all children). I think that these could be useful properties of PlanNode, as together they mean that the estimates are very reliable (unless table stats are wrong). They could be merged to a property like hasHardEstimates. Computing them before runtime filter pruning could also make the planner faster as we could decide for some filters quickly that we can't eliminate them and remove them from highFppFilters. http://gerrit.cloudera.org:8080/#/c/20366/11/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@863 PS11, Line 863: isEligibleBuild The name could be more descriptive, e.g. isEligibleForPruning -- To view, visit http://gerrit.cloudera.org:8080/20366 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I494533bc06da84e606cbd1ae1619083333089a5e Gerrit-Change-Number: 20366 Gerrit-PatchSet: 11 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 07 Sep 2023 15:43:55 +0000 Gerrit-HasComments: Yes
